Hello everyone! I’m excited to share my first project, which I completed without any hints. I’m on the path to becoming a Business Intelligence Data Analyst. My first language is Russian, and this is my first experience learning in English, which I really enjoy.
If you have any tips on how to improve my code, I’d love to hear them! （＿ε＿）
paitings=['The Two Fridas', 'My Dress Hangs Here', 'Tree of Hope', 'Self Portrait With Monkeys']
dates=[1939,1933,1946,1940]
paitings=zip(paitings,dates)
paiting_change=list(paitings)
paiting_change.append(('The Broken Column', 1944))
paiting_change.append(('The Wounded Deer', 1946))
paiting_change.append(('Me and My Doll', 1937))
print(paiting_change)
print(len(paiting_change))
audio_tour_number=range(1,len(paiting_change)+1)
print(audio_tour_number)
master_list = [(number, title, year) for number, (title,year) in zip(audio_tour_number, paiting_change)]
print(master_list)
Congrats on finishing the project.
A couple things to consider:
- You could use
list() with zip():
paintings = list(zip(paintings, dates))
print(paintings)
[('The Two Fridas', 1939), ('My Dress Hangs Here', 1933), ('Tree of Hope', 1946), ('Self Portrait With Monkeys', 1940)]
- And, for Task 6(?) they wanted you to generate a list of audio tour numbers, like:
audio_tour_number = list(range(1, 8)) #you need the start and stop args here. else it defaults to 0.
print(audio_tour_number)
[1, 2, 3, 4, 5, 6, 7]
2 Likes
Hi, congratulations.
I’m working on the Data and Programming Foundations for AI skill path. This is also my first time conducting code reviews!
According to the initial checklist that will apply to all types of projects provided by Code Review: Frida Kahlo Retrospective:
- The code runs and fulfils its intended purpose.
- The code is efficient and handles errors gracefully.
- The code has a consistent format.
- The code is commented where necessary.
Here are code reviews:
- For Task 3, you should save the new list with the name “paintings”, and the
print(painting_change) is missing.
- For Task 7, there’s a more efficient way to fulfil:
master_list = list(zip(audio_tour_number, paintings)). It’s simpler.
- It’s fine.
- The code review is conducted according to the task requirements. If you comment on your code to indicate which task you work on, it might be easier for others to review your code.
(And, it should be “paintings”, not “paiting”. The typo might be confusing.)
Happy coding 
If you read the post above yours (mine), I cover the items that your post mentions.
If you want a code review, please create a new topic and a link to your code (rather than reply to an already solved topic).