First PR - Newbie question don't know what to do next

Community Off Topic
1

This my first ever contribution to HF library and I read somewhere that new contributors have to have their workflow runs approved by maintainers for PR to GitHub – everything was going well but now I don’t know what should I do or what does this even mean; btw I also don’t know who the maintainer is to ping;

I’m extremely thankful for anyone who can help :pray:

prr
prr1308×559 45.7 KB

2

Is this a CC thing, or something else?

3

I’m so sorry! but I don’t get what CC refers to here;

4

Codecademy.

Is your question related to a Codecademy project or lesson?

You can always check the GitHub docs:

https://docs.github.com/en/pull-requests

1 Like
5

Nice, you have your changes approved from huggingface, fun!

I guess the CI/CD of it needs an additional workflow approval on top of the change approvals. You would best get your answer from the maintainers of the repo than here.

1 Like
6

Got it, but what is the best way to do so on github, pinging doesn’t seem to work (pinged the the last reviewer), not sure the best practice here in this scenerio, thanks:

7

Oh, no it’s not related to Codecademy; thanks

8

If it’s not detailed in their contribution guide then the best you’ll have to do is wait, maybe they have some forum/discord specific to huggingface where you can learn more info but it’s going to be very repo-dependent.

1 Like
9

Thanks a lot! I joined their dicord and will reach out to ask someone; thanks again!

1 Like