Finished Battleship! ... I thought. It won't show "X"


I thought I had all of my code correct but whenever I type an incorrect guess, it won’t show an X. It will only show an X at the end WHERE the ship is (oh lord). I am new to programming so could someone help me or show me where I went wrong?

Here is my code:

from random import randint

board = []

for x in range(0, 5):
  board.append(["O"] * 5)

def print_board(board):
  for row in board:
    print " ".join(row)


def random_row(board):
  return randint(0, len(board) - 1)

def random_col(board):
  return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)

for turn in range(4):
  print "Turn", turn + 1
  guess_row = int(raw_input("Guess Row: "))
  guess_col = int(raw_input("Guess Col: "))

  if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
    if guess_row not in range(5) or \
      guess_col not in range(5):
      print "Oops, that's not even in the ocean."
    elif board[guess_row][guess_col] == "X":
      print( "You guessed that one already." )
      print "You missed my battleship!"
    if turn == 3:
      print "Game Over"
      board[guess_row][guess_col] = "X"

**2nd Edit: I figured out the problem! Sometimes it takes a break from the screen and some time before you get back on and fix your own code :joy:

I added this under my last else statement:**

board[guess_row][guess_col] == "X"


We need to use markdown similar to markup used by HTML, XML, MathML, etc…


code goes here


The backtick character is usually on the same key as the tilde ~.

If you can still edit, give it a try; else, let me know and I’ll format it for you.


It won’t matter much, but I would put the last line before the if statement.

    print (“You missed my battleship!”)
    board[guess_row][guess_col] = “X”
    if turn == 3: 
        print ("Game Over")
        board[ship_row][ship_col] = “B”
    print (board)


This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.