Excursion Project with Semantic

orlandonunez90967719 · December 13, 2020, 5:45am

Hey guys I would like to know if I used Semantic properly in this project & if I should have used a class tag to style:

“

Excursion remembers places you like, and recommends new points of interest around you.

”

along with the footer so they are both the same?

ocnunez/excursion/blob/main/index.html

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Excursion</title>
    <link rel="stylesheet" href="resources/css/style.css" type="text/css">
</head>
<body>
    <header>
        <h1 class="header--main">Discover hidden places in the world around you</h1>
    </header>
    <main>
        <section>
            <p><a class="link--1" href="#">Download Excursion (Coming soon!)</a></p>
            <video muted autoplay loop>
                <source src="resources/video/excursion.mp4" type="video/mp4">
            </video>
        </section>

This file has been truncated. show original

8-bit-gaming · December 14, 2020, 10:25pm

Hey there and welcome to the Codecademy forums!!

Nicely done!! There are only a couple things I noticed to point out.
The first thing that caught my eye were your <img> tags. Currently they are both nested in a <p> which is supposed to hold text. For semantic purposes you should nest it in a <figure> tag.
I’m guessing you used the paragraph element in order to space them apart better, if so it would be better to style them with margin:

orlandonunez90967719 · December 13, 2020, 6:08pm

thank you so much! I was following the instructions but i will definitely edit this code and keep that in mind for future codes.