Does not return "Oops, that's not even in the ocean."


#1

Below is my code

from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

board[guess_row][guess_col] = "X"
if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
else:

if guess_row not in range(5) or guess_col not in range(5):
    print "Oops, that's not even in the ocean."

elif board[guess_row][guess_col] == "X":
    print "You guessed that one already."

else:
    print "You missed my battleship!"

print_board(board)

print
print board[guess_row][guess_col]

"


#2

Hi :smiley:

Let me explain you, why it can't work this way :frowning:

You want to draw a "X" on the board with the guessed row and column, but you want to do it without checking if it's even in the ocean or not, so if I type 7/7, it will try to draw a "X", before it even tells me that I'm outside.

One way to fix it, is to put board[guess_row][guess_col] = "X" here:

This way, it will only put a "X", if when you miss or hit the ship. :slightly_smiling:


#3

Thank you! This helps a lot!