Dasmotos Arts & Crafts code review

Hey guys, I finally uploaded my project to github https://github.com/PatriciaIsaacs1997/Codecademy-Off-Platform-Project-Dasmoto-s-Arts-Crafts. Code is pretty standard for Dasmotos Arts & Crafts, but would still love a look over and review from anyone willing. You can even critique the way I did my github repository, as well for it.

For those of you not wanting to be redirected/have a new tab pop open:
HTML:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <link href="./resources/index.css" rel="stylesheet" type="text/css">
    <title>Dasmoto's Arts & Crafts</title>
</head>
<body>
    <header id="header" block-size="50%">
        <h1>Dasmoto's Arts & Crafts</h1>
    </header>
    <!--Brush section-->
    <section id="brushes">
        <h2>Brushes</h2>
            <img src="./resources/images/image2.jpeg" alt="">
                <h3>Hacksaw Brushes</h3>
                    <p>
                        Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. 
                            <strong>Starting at $3.00 / brush.</strong>
                    </p>
    </section>
    <!--Frame section-->
    <section id="frames">
        <h2>Frames</h2>
            <img src="./resources/images/image3.jpeg" alt="">
                <h3>Art Frames (assorted)</h3>
                    <p>
                        Assorted frames made of different material, including MDF, birchwood, and PDE. Select frames can be sanded and painted according to your needs.
                        <strong>Starting at $2.00 / frame</strong>
                    </p>
    </section>            
    <!--Paint section-->
    <section id="paint">
        <h2>Paint</h2>
            <img src="./resources/images/image4.jpeg" alt="">
                <h3>Clean Finnish Paint</h3>
                    <p>
                        Imported paint from Finland. Over 256 colors available in store, varying in quantity (1 oz. to 8 oz.). Clean Finnish paint microbinds to canvas, increasing the finish and longevity of any artwork.
                        <strong>Starting at $5.00 / tube.</strong>
                    </p>
    </section>
</body>
</html>

CSS:

* {
    font-family: Helvetica, Arial, sans-serif;
}
#header {
    block-size: auto;
    background-image: url('../resources/images/image1.jpeg');
}
h1 {
    font-size: 100px;
    font-weight: bold;
    color: khaki;
    text-align: center;
}    
h2 {
    font-size: 32px;
    font-weight: bold;
    color: white;
}
#brushes h2 {
    background-color: mediumspringgreen;
    background-image: url('./resources/images/image2.jpeg');
}
#frames h2 {
    background-color: lightcoral;
    background-image: url('./resources/images/image3.jpeg');
}
#paint h2 {
    background-color: skyblue;
    background-image: url('./resources/images/image4.jpeg');
}
strong {
    font-weight: bold;
    color: blue;
}
1 Like

Hey Patricia !

I just finished my Off Platform Dasmotos but not online yet.
It’s very interesting to compare each others code, it is nice to see how others get to the same result with different code.
I share you my codes for that project :

HTML

Dasmotos project
<div>
    <h1>Dasmoto's Arts & Crafts</h1>        
</div>

<div>
    <h2 class="Brushes"> Brushes</h2>
    <img class="hacksaw" src="ressources/hacksaw.jpeg" alt="des pinceaux empiler" />
</div>

<div>
    <h3>Hacksaw Brushes</h3>
    <p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Availiable in different sizes. <span>Starting at $3.00 / Brush.</span></p>
</div>

<div>
    <h2 class="Frames">Frames</h2>
    <img class="Frames picture" src="ressources/frames.jpeg" alt="des cadres photo de couleur"/>
</div>

<div>
    <h3>Art Frames (assorted)</h3>
    <p>Assorted frames made of different material, including MDF, birchwood, and PDE. Select frames can be sanded and painted according to your needs. <span>Starting at $2.00 / frame.</span></p>
</div>

<div>
    <h2 class="Paint">Paint</h2>
    <img class="Finnish" src="ressources/finnish.jpeg" alt=" Tube de peintures de couleurs">
</div>

<div>
    <h3>Clean Finnish Paint</h3>
    <p>Imported paint from Finland. Over 256 colors available in-store, varying in quantity (1 oz. to 8 oz.). Clean Finnish paint microbinds to canvas, increasing the finish and longevity of any artwork.<span> Starting at $5.00 / tube.</span></p>
</div>

CSS :

h1 {
font-family: Helvetica;
font-size: 100px;
font-weight: bold;
color: khaki;
background: url(…/ressources/pattern.jpeg);
text-align: center;
background-size: cover;

}
.Brushes {
font-family: Helvetica;
font-size: 32px;
color: white;
background-color: mediumspringgreen;
}

.Frames {
font-family: Helvetica;
font-size: 32px;
color: white;
background-color: lightcoral;
}
.Paint {
font-family: Helvetica;
font-size: 32px;
color: white;
background-color: lightblue;
}
span {
font-weight: bold;
color: blue;
}

1 Like

I like it, the code is clean and easy to follow.

1 Like