Well done on your first website - and publishing it on GitHub (which makes it so much easier to code review!).
It’s looking good, and you hit almost all the requirements for the project. Tips/feedback:
- It’s a good idea to share a link to the course page and/or the design spec so reviewers understand your project. In this case I have done the project, but through a different path, and there may be some minor differences. You’re the second person I’ve seen mention “vertically centered” text, however the spec I have access to says “centered horizontal”…
- Nice clear code, you’ve structured and written things well
- While the design spec didn’t state everything explicitly, the goal is to try to replicate what is in the design spec. For this reason, try to get the banner the same rather than larger, and the h1 title to be on one line when the browser is at full screensize.
- There’s redundant code for the blue price text, where it has been coded “bold” both in the css stylesheet and inline in the html. I would recommend keeping all the css in the stylesheet (hypothetically, if design changes were made, you could easily change them in the stylesheet and not have to hardcode many instances in the html).
- It may not have been covered in your skill path, but where possible use semantic HTML instead of generic html… currently each of the sections is wrapped in a
<div> where the semantic HTML option would be
section tags instead.
- It’s a good idea to include a backup font in case the first font doesn’t load e.g.
font-family: Helvetica, Arial, sans-serif;
- Extra marks - your design doesn’t break when it is viewed on a smaller screen, like mobile.
I’d also highly recommend doing a code review for someone else… examining your code against another person’s will help you see more… this code review made me realise that my own design breaks on smaller/mobile screens - so I will have to look into fixing that!
Let me know if anything I’ve written above isn’t clear, or you want to discuss. It’s also fine to disagree with the above suggestions - it is your project, and there is nothing wrong with what you have completed.