Danger Will Robinson!


#1

I can't figure out what's wrong with my code. There's two problems:
One, it doesn't give me the "Congratulations" statement that I should get.
Two, it states that I didn't replace the "X" even though it clearly shows that I did.


https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/2?curriculum_id=4f89dab3d788890003000096#


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

print ship_row
print ship_col

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

# Write your code below!

if guess_row == ship_row and guess_col == ship_col:
    print ("Congratulations! you sank my battleship!")    
else:
    print "You missed my battleship!"
    board[ship_row][ship_col] = "X"
    print_board(board)


#2

1) It crashes. Fixing that addresses your first question.

$ python2 webace45819.py 
O O O O O
O O O O O
O O O O O
O O O O O
O O O O O
Traceback (most recent call last):
  File "webace45819.py", line 20, in <module>
    print ship_row
NameError: name 'ship_row' is not defined

2) That's cause it exits immediately after taking input, there's no code to
print out the board after taking input, so it doesn't.


#3

change your code to ---->>

board[guess_row][guess_col] = "X"

#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.