Danger, Will Robinson! Possible bug!


#1



Following code is accepted by Codeacademy, but in fact it is incorrect! Using user inputs 2 and 3.

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))
print guess_row
print guess_col


if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row]="X"
    board[guess_col]="X"
    print_board(board)


Code should give an error message because rows 2 and 3 are replaced with "X".

Correct code should be:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))
print guess_row
print guess_col


# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col]="X"
    print_board(board)


#2

Yes, @kracode , that is a bug in Codecademy's submission correctness test (SCT) for this exercise.

Thanks; it is cool that you discovered it. :sunglasses:

Link to exercise: Battleship!: Exercise 11: Danger, Will Robinson!!.


#3