Credit Card Checker - validateCred getting every iteration in output

Get Help JavaScript
,
#1

**Hi everyone, **

**I was wondering if any of you could help me figure out what I’m doing wrong in the Credit Card Checker exercise for the validateCred function. My output thus far is giving me each and every iteration of my loop, when I really only want the last one. Trouble is, I don’t know how to just get that one. **

This is my code (I’ve left out all the additional arrays and only included the one I’m testing with):

// All valid credit card numbers
const valid1 = [4, 5, 3, 9, 6, 7, 7, 9, 0, 8, 0, 1, 6, 8, 0, 8];


// Add your functions below:
const validateCred = (array) => {
  
  array.reverse();
  const cardLength = array.length;
  const checkDigit= array[0];
  let newArray = [];
  
  for (let i = 1; i < cardLength; i++) {
    
    if (i % 2 === 0) {
      newArray.push(array[i]);
      }
    else if (i % 2 !== 0) {
      const odd = array[i] * 2;
      if (odd > 9){
        newArray.push(odd - 9);
      }
      else {
        newArray.push(odd);
      }
    }

    const x = newArray;
    console.log(x);
  
    const newArraySum = x.reduce((acc, val) => {
    return acc + val;
    });
    
    totalSum = newArraySum + checkDigit;
    console.log(totalSum);
    
    
    /*if (totalSum % 10 === 0){
      return true;
    }
    else {
      return false;
    }*/
  }
}
  validateCred (valid1);

The result I end up with is:

[ 0 ]
8
[ 0, 8 ]
16
[ 0, 8, 3 ]
19
[ 0, 8, 3, 1 ]
20
[ 0, 8, 3, 1, 0 ]
20
[ 0, 8, 3, 1, 0, 8 ]
28
[ 0, 8, 3, 1, 0, 8, 0 ]
28
[ 0, 8, 3, 1, 0, 8, 0, 9 ]
37
[ 0, 8, 3, 1, 0, 8, 0, 9, 5 ]
42
[ 0, 8, 3, 1, 0, 8, 0, 9, 5, 7 ]
49
[ 0, 8, 3, 1, 0, 8, 0, 9, 5, 7, 3 ]
52
[ 0, 8, 3, 1, 0, 8, 0, 9, 5, 7, 3, 9 ]
61
[ 0, 8, 3, 1, 0, 8, 0, 9, 5, 7, 3, 9, 6 ]
67
[ 0, 8, 3, 1, 0, 8, 0, 9, 5, 7, 3, 9, 6, 5 ]
72
[ 0, 8, 3, 1, 0, 8, 0, 9, 5, 7, 3, 9, 6, 5, 8 ]
80
#2

Hi, welcome to the forums! Without looking at it in too much detail, I believe you’ve let your for-loop envelop more than you wanted to. I commented on some of the code.

for (let i = 1; i < cardLength; i++) {
    
    if (i % 2 === 0) {
      newArray.push(array[i]);
      }
    else if (i % 2 !== 0) { // when does this close?
      const odd = array[i] * 2;
      if (odd > 9){
        newArray.push(odd - 9);
      }
      else {
        newArray.push(odd);
      }
    } // which means this doesn't close the for-loop

    const x = newArray;
    console.log(x);
#3

Oh my gosh. Something so simple. I moved the } where you mentioned and it worked. And to think I spent hours trying to figure it out. haha. Thank you!!!

#4

No problem!

In javascript that’s the first thing I look out for when it’s a strange error I can’t wrap my head around, I just make sure all my brackets are taken care of. With enough practice you start getting better habits about tracking them, and seeing when they’re not closed.