Credit Card Checker Challenge Project (JavaScript)

trevonwilson21493217 · January 9, 2022, 4:04am

I am almost finished with the challenge, but I just learned that my function is not working properly when it comes to AMEX cards. I’ve been staring at my code for some time now… But that’s the only problem I am having at the moment. Here’s the code I am referring to:

const valid3 = [3, 7, 1, 6, 1, 2, 0, 1, 9, 9, 8, 5, 2, 3, 6];
const validateCred = (arr) => {
  let sum = 0;
  for (let i = arr.length - 1; i >= 0; i--){
    let digit = arr[i];
    
    if(i % 2 == 0 ){
      digit *= 2;   
      }
    if(digit > 9){ 
      digit -= 9;
      }
    //console.log(digit);
    sum += digit;
  }
  return sum % 10 === 0 ? 'Valid number.' : 'Invalid number.. '
} 

console.log(validateCred(valid3));

I will clean my code up later. I am trying to understand the concepts now. But I can’t tell what I am missing at the moment.

trevonwilson21493217 · January 9, 2022, 4:55am

This little piece of code here is what I was missing " (arr.length - i) % 2 == 0 "… What is the significance of this piece of code? Why did I need that versus " i % 2 == 0 "? Does (arr.length - i) remove the rightest number?

bit7547509295 · January 9, 2022, 7:47pm

Hi! I’ve got most of a solution, but there’s one issue that I can’t resolve. In the first function, which checks whether cc numbers are valid or not, my code keeps changing the input array, but I intend it to create a copy of the input array that I change. In other words, I want to double the digits of the copy, but it seems to be doing the original. This doesn’t cause a problem for this function, but it causes problems down the road when I try to identify the companies, since I don’t have the originals anymore. Here’s the code, along with some comments and tests that highlight the problem:

const valid1 = [4, 5, 3, 9, 6, 7, 7, 9, 0, 8, 0, 1, 6, 8, 0, 8]; //this is so I can test the function and demonstrate the problem I'm having

function validateCred(ccNumber) {

  let doubledArray = ccNumber; //this is where I create the copy of the cc number to work with

  for (let i=ccNumber.length-2; i>= 0; i = i-2){

    doubledArray[i] = 2*doubledArray[i];

    //this is changing ccNumber, as is shown by these tests, which output identical arrays, even though I intend the ccNumber to not change:

   console.log(doubledArray);

    console.log(ccNumber)

    if (doubledArray[i]>9) {

      doubledArray[i]=doubledArray[i]-9

    }

  }

 const reducer = (previousValue, currentValue) => previousValue + currentValue;

let sum = doubledArray.reduce(reducer);

  if (sum % 10==0) {

    return true

  } else {

    return false

  }

}

validateCred(valid1)  //this is to test the function and demonstrate the problem, which is that ccNumber changes

janbazant1107978602 · January 9, 2022, 11:18pm

I see a problem here:

let doubledArray = ccNumber; //this is where I create the copy of the cc number to work with

The = doesn’t actually copy the array, it just makes a new reference to it, since an array is a kind of object.
thus doubledArray and ccNumber are the same array.
and changing what’s in doubledArray changes what’s in ccNumber.

One workaround is to use Array.from() to make a new array.
like this:

let doubledArray = Array.from(ccNumber);

Look up some of the other JavaScript array methods too, they may be useful to you.

janbazant1107978602 · January 9, 2022, 11:43pm

I liked your approach;
using a variable or counter to keep track of the position in the array relative to the end of the array (to know how far you are from the end of the array in each iteration) was a good idea.

bit7547509295 · January 10, 2022, 1:14am

Oh, thanks so much! I think I learned that once, but obviously forgot and/or never really understood it. Anyways, this helped and it’s working well now.

Thanks again!

trevonwilson21493217 · January 10, 2022, 4:55am

github.com

Meta-Veloper/cc-checker-project/blob/main/script.js

// All valid credit card numbers
const valid1 = [4, 5, 3, 9, 6, 7, 7, 9, 0, 8, 0, 1, 6, 8, 0, 8];
const valid2 = [5, 5, 3, 5, 7, 6, 6, 7, 6, 8, 7, 5, 1, 4, 3, 9];
const valid3 = [3, 7, 1, 6, 1, 2, 0, 1, 9, 9, 8, 5, 2, 3, 6];
const valid4 = [6, 0, 1, 1, 1, 4, 4, 3, 4, 0, 6, 8, 2, 9, 0, 5];
const valid5 = [4, 5, 3, 9, 4, 0, 4, 9, 6, 7, 8, 6, 9, 6, 6, 6];

// All invalid credit card numbers
const invalid1 = [4, 5, 3, 2, 7, 7, 8, 7, 7, 1, 0, 9, 1, 7, 9, 5];
const invalid2 = [5, 7, 9, 5, 5, 9, 3, 3, 9, 2, 1, 3, 4, 6, 4, 3];
const invalid3 = [3, 7, 5, 7, 9, 6, 0, 8, 4, 4, 5, 9, 9, 1, 4];
const invalid4 = [6, 0, 1, 1, 1, 2, 7, 9, 6, 1, 7, 7, 7, 9, 3, 5];
const invalid5 = [5, 3, 8, 2, 0, 1, 9, 7, 7, 2, 8, 8, 3, 8, 5, 4];

// Can be either valid or invalid
const mystery1 = [3, 4, 4, 8, 0, 1, 9, 6, 8, 3, 0, 5, 4, 1, 4];
const mystery2 = [5, 4, 6, 6, 1, 0, 0, 8, 6, 1, 6, 2, 0, 2, 3, 9];
const mystery3 = [6, 0, 1, 1, 3, 7, 7, 0, 2, 0, 9, 6, 2, 6, 5, 6, 2, 0, 3];
const mystery4 = [4, 9, 2, 9, 8, 7, 7, 1, 6, 9, 2, 1, 7, 0, 9, 3];
const mystery5 = [4, 9, 1, 3, 5, 4, 0, 4, 6, 3, 0, 7, 2, 5, 2, 3];

This file has been truncated. show original

borisperesechensky53 · January 10, 2022, 10:23pm

github.com

windserenity/Credit-Card-Checker-Challenge-Project-/blob/main/main.js

// All valid credit card numbers
const valid1 = [4, 5, 3, 9, 6, 7, 7, 9, 0, 8, 0, 1, 6, 8, 0, 8]
const valid2 = [5, 5, 3, 5, 7, 6, 6, 7, 6, 8, 7, 5, 1, 4, 3, 9]
const valid3 = [3, 7, 1, 6, 1, 2, 0, 1, 9, 9, 8, 5, 2, 3, 6]
const valid4 = [6, 0, 1, 1, 1, 4, 4, 3, 4, 0, 6, 8, 2, 9, 0, 5]
const valid5 = [4, 5, 3, 9, 4, 0, 4, 9, 6, 7, 8, 6, 9, 6, 6, 6]

// All invalid credit card numbers
const invalid1 = [4, 5, 3, 2, 7, 7, 8, 7, 7, 1, 0, 9, 1, 7, 9, 5]
const invalid2 = [5, 7, 9, 5, 5, 9, 3, 3, 9, 2, 1, 3, 4, 6, 4, 3]
const invalid3 = [3, 7, 5, 7, 9, 6, 0, 8, 4, 4, 5, 9, 9, 1, 4]
const invalid4 = [6, 0, 1, 1, 1, 2, 7, 9, 6, 1, 7, 7, 7, 9, 3, 5]
const invalid5 = [5, 3, 8, 2, 0, 1, 9, 7, 7, 2, 8, 8, 3, 8, 5, 4]

// Can be either valid or invalid
const mystery1 = [3, 4, 4, 8, 0, 1, 9, 6, 8, 3, 0, 5, 4, 1, 4]
const mystery2 = [5, 4, 6, 6, 1, 0, 0, 8, 6, 1, 6, 2, 0, 2, 3, 9]
const mystery3 = [6, 0, 1, 1, 3, 7, 7, 0, 2, 0, 9, 6, 2, 6, 5, 6, 2, 0, 3]
const mystery4 = [4, 9, 2, 9, 8, 7, 7, 1, 6, 9, 2, 1, 7, 0, 9, 3]
const mystery5 = [4, 9, 1, 3, 5, 4, 0, 4, 6, 3, 0, 7, 2, 5, 2, 3]

This file has been truncated. show original

It feels like the way I arrived at the answer is a bit randomly strange, looking over other peoples work it seems I have to many steps, would appreciate some feedback.

Thanks all.

procoder336 · January 11, 2022, 8:06pm

I dont think there is a right or wrong if your code is working like the lesson says you always have time to refactor and shorten your code check out mines I think im like 15 lines short of you

// Add your functions below:

const validateCred = (arr) => {

// created a new arr variable with the value of the enter arr reversed.

let newArr = arr.reverse();

// New variable that will hold the sum of the entered arr

let sum = 0;

for (let i = 0; i < newArr.length; i++) {

 if (i % 2 == 1) {

// multiply every other value by 2

arr[i] *= 2;

// nested if statement to test another condition

   if (arr[i] > 9) {

// if doubled arr value exceeds 9 take away 9

  arr[i] -= 9;

 }

}

// adding up all the arr values

sum += arr[i]; //end of for loop

}

// console.log(sum);

if (sum % 10 == 0) {

return true;

} else {

return false;

}

const findInvalidCards = (arrNest) => {

// The variable used to return the nest array list of invalid cards

const newArrNest = ;

arrNest.forEach(function (array) {

// console.log(validateCred(array)); //Test Statement

// conditional statement to add the invalid cards to the newArrNest

if (validateCred(array) == false) {

  newArrNest.push(array);

  // console.log(newArrNest); //test Statement

}

})

return newArrNest;

}

function idInvalidCardCompanies(invalidArrNest) {

const companyArr = ;

// console.log(invalidArrNest);

invalidArrNest.forEach(function (array) {

if (array[0] == 3 && companyArr.indexOf('Amex (American Express)') == -1) {

  

  companyArr.push('Amex (American Express)');

} else if (array[0] == 4 && companyArr.indexOf('Visa') == -1) {

  

  companyArr.push('Visa');

} else if (array[0] == 5 && companyArr.indexOf('Mastercard') == -1) {

  companyArr.push('Mastercard');

} else if (array[0] == 6 && companyArr.indexOf('Discover') == -1) {

  companyArr.push('Discover');

} else {

  console.log('This card Company was not found');

}

})

return companyArr;

}

// console.log(idInvalidCardCompanies(findInvalidCards(batch)));

// console.log(findInvalidCards(batch));

// console.log(validateCred(invalid1));

// console.log(validateCred(valid1));

borisperesechensky53 · January 11, 2022, 8:24pm

True indeed. I hope to re factor to a more concise format.

procoder336 · January 11, 2022, 8:40pm

When i looked over your code the only thing i really can find is that the array was not reversed what method did you choose to go with when completing the project here take a look at my code nothing is wrong with using
i % 2 == 0

// Add your functions below:
const validateCred = (arr) => {
// created a new arr variable with the value of the enter arr reversed.
let newArr = arr.reverse();
// New variable that will hold the sum of the entered arr
let sum = 0;
for (let i = 0; i < newArr.length; i++) {
if (i % 2 == 1) {
// multiply every other value by 2
arr[i] *= 2;
// nested if statement to test another condition
if (arr[i] > 9) {
// if doubled arr value exceeds 9 take away 9
arr[i] -= 9;
}
}
// adding up all the arr values
sum += arr[i]; //end of for loop
}

// console.log(sum);
if (sum % 10 == 0) {
return true;
} else {
return false;
}
}

2662409340 · January 12, 2022, 11:56pm

Hi!
This is my solution.
Maybe someone can check? ))

github.com

pavlalen/ccc/blob/main/checker

// All valid credit card numbers
const valid1 = [4, 5, 3, 9, 6, 7, 7, 9, 0, 8, 0, 1, 6, 8, 0, 8]
const valid2 = [5, 5, 3, 5, 7, 6, 6, 7, 6, 8, 7, 5, 1, 4, 3, 9]
const valid3 = [3, 7, 1, 6, 1, 2, 0, 1, 9, 9, 8, 5, 2, 3, 6]
const valid4 = [6, 0, 1, 1, 1, 4, 4, 3, 4, 0, 6, 8, 2, 9, 0, 5]
const valid5 = [4, 5, 3, 9, 4, 0, 4, 9, 6, 7, 8, 6, 9, 6, 6, 6]

// All invalid credit card numbers
const invalid1 = [4, 5, 3, 2, 7, 7, 8, 7, 7, 1, 0, 9, 1, 7, 9, 5]
const invalid2 = [5, 7, 9, 5, 5, 9, 3, 3, 9, 2, 1, 3, 4, 6, 4, 3]
const invalid3 = [3, 7, 5, 7, 9, 6, 0, 8, 4, 4, 5, 9, 9, 1, 4]
const invalid4 = [6, 0, 1, 1, 1, 2, 7, 9, 6, 1, 7, 7, 7, 9, 3, 5]
const invalid5 = [5, 3, 8, 2, 0, 1, 9, 7, 7, 2, 8, 8, 3, 8, 5, 4]

// Can be either valid or invalid
const mystery1 = [3, 4, 4, 8, 0, 1, 9, 6, 8, 3, 0, 5, 4, 1, 4]
const mystery2 = [5, 4, 6, 6, 1, 0, 0, 8, 6, 1, 6, 2, 0, 2, 3, 9]
const mystery3 = [6, 0, 1, 1, 3, 7, 7, 0, 2, 0, 9, 6, 2, 6, 5, 6, 2, 0, 3]
const mystery4 = [4, 9, 2, 9, 8, 7, 7, 1, 6, 9, 2, 1, 7, 0, 9, 3]
const mystery5 = [4, 9, 1, 3, 5, 4, 0, 4, 6, 3, 0, 7, 2, 5, 2, 3]

This file has been truncated. show original

heartlines18 · January 13, 2022, 11:48am

Really enjoyed this project, specifically converting invalid numbers into valid numbers.
Would like some feedback.

github.com

Amit-R328/credit_card_checker/blob/master/script.js



// All valid credit card numbers
const valid1 = [4, 5, 3, 9, 6, 7, 7, 9, 0, 8, 0, 1, 6, 8, 0, 8];
const valid2 = [5, 5, 3, 5, 7, 6, 6, 7, 6, 8, 7, 5, 1, 4, 3, 9];
const valid3 = [3, 7, 1, 6, 1, 2, 0, 1, 9, 9, 8, 5, 2, 3, 6];
const valid4 = [6, 0, 1, 1, 1, 4, 4, 3, 4, 0, 6, 8, 2, 9, 0, 5];
const valid5 = [4, 5, 3, 9, 4, 0, 4, 9, 6, 7, 8, 6, 9, 6, 6, 6];

// All invalid credit card numbers
const invalid1 = [4, 5, 3, 2, 7, 7, 8, 7, 7, 1, 0, 9, 1, 7, 9, 5];
const invalid2 = [5, 7, 9, 5, 5, 9, 3, 3, 9, 2, 1, 3, 4, 6, 4, 3];
const invalid3 = [3, 7, 5, 7, 9, 6, 0, 8, 4, 4, 5, 9, 9, 1, 4];
const invalid4 = [6, 0, 1, 1, 1, 2, 7, 9, 6, 1, 7, 7, 7, 9, 3, 5];
const invalid5 = [5, 3, 8, 2, 0, 1, 9, 7, 7, 2, 8, 8, 3, 8, 5, 4];
const invalid6 = [5, 3, 8, 2, 0, 1, 9, 7, 7, 2, 8, 8, 3, 8, 5, 4]

// Can be either valid or invalid
const mystery1 = [3, 4, 4, 8, 0, 1, 9, 6, 8, 3, 0, 5, 4, 1, 4];
const mystery2 = [5, 4, 6, 6, 1, 0, 0, 8, 6, 1, 6, 2, 0, 2, 3, 9];

This file has been truncated. show original

nyrracnala5775919718 · January 13, 2022, 4:10pm

Hello All,

Sharing as instructed Codecademy export · GitHub

The only extra effort left to me would be a proper factory function for the company object array. Sorry for the lack of comment code.

deanh1990 · January 13, 2022, 7:17pm

Hello all,

I’ve got to the end of task 5 and have tried using switch and else if statements which give 2 different company arrays. I’m not sure which is correct.

Should the ‘company not found’ be included as there are card number arrays which don’t start with correlating numbers. The else if statement i wrote includes ‘company not found’ due to reason above.

Unsure which is correct!

mtf · January 13, 2022, 7:21pm

    default: 'company not found'

deanh1990 · January 13, 2022, 7:47pm

sorry i’m not sure what you mean?

I have the default at the end of the switch statement but it doesn’t get returned in the array, just amex and discover.

When I used else if statements amex, discover and company not found are returned in the array.

I’m not sure if it should be returned or not is where i’m at a loss. I think it should be and can see why its not being returned if so. For the default I haven’t push() ed it into the array…

mtf · January 13, 2022, 8:20pm

What does your switch look like?

deanh1990 · January 13, 2022, 8:30pm

const idInvalidCardCompanies = cardNums => {

let companies =

for (let i = 0; i < cardNums.length; i ++) {

switch (cardNums[i][0]) {

  case 3:

  if (companies.indexOf('Amex') === -1) {

      companies.push('Amex');

    };

    break;

    case 4:

  if (companies.indexOf('Visa') === -1) {

      companies.push('Visa');

    };

    break;

    case 5:

  if (companies.indexOf('Mastercard') === -1) {

      companies.push('Mastercard');

    };

    break;

    case 6:

    if (companies.indexOf('Discover') === -1) {

      companies.push('Discover');

    };

    break;

    default:  'Company not found'


};

};

return companies

};

not sure how to post it so it looks nice and neat. hopefully it pastes alright.

mtf · January 13, 2022, 8:33pm

Shouldn’t you be checking the first digit? That is what the switch is set up for. Remove the if statement and just push the company name.