Credit Card Checker and nested array

[stx182]

My function only printing random true and false statements it seems.

validateCred() is definitly working, but i don’t really know how to call it in another function to access the nested batch.

I also want to access the validateCred() function inside the findInvalidCards() function. Can you might tell me the right syntax for this? I’m now working on it since 30 hours because i began totally wrong without achieving anything.

I only logged it to see if its working

const valid1 = [4, 5, 3, 9, 6, 7, 7, 9, 0, 8, 0, 1, 6, 8, 0, 8];
const valid2 = [5, 5, 3, 5, 7, 6, 6, 7, 6, 8, 7, 5, 1, 4, 3, 9];
const valid3 = [3, 7, 1, 6, 1, 2, 0, 1, 9, 9, 8, 5, 2, 3, 6];
const valid4 = [6, 0, 1, 1, 1, 4, 4, 3, 4, 0, 6, 8, 2, 9, 0, 5];
const valid5 = [4, 5, 3, 9, 4, 0, 4, 9, 6, 7, 8, 6, 9, 6, 6, 6];

// All invalid credit card numbers
const invalid1 = [4, 5, 3, 2, 7, 7, 8, 7, 7, 1, 0, 9, 1, 7, 9, 5];
const invalid2 = [5, 7, 9, 5, 5, 9, 3, 3, 9, 2, 1, 3, 4, 6, 4, 3];
const invalid3 = [3, 7, 5, 7, 9, 6, 0, 8, 4, 4, 5, 9, 9, 1, 4];
const invalid4 = [6, 0, 1, 1, 1, 2, 7, 9, 6, 1, 7, 7, 7, 9, 3, 5];
const invalid5 = [5, 3, 8, 2, 0, 1, 9, 7, 7, 2, 8, 8, 3, 8, 5, 4];

// Can be either valid or invalid
const mystery1 = [3, 4, 4, 8, 0, 1, 9, 6, 8, 3, 0, 5, 4, 1, 4];
const mystery2 = [5, 4, 6, 6, 1, 0, 0, 8, 6, 1, 6, 2, 0, 2, 3, 9];
const mystery3 = [6, 0, 1, 1, 3, 7, 7, 0, 2, 0, 9, 6, 2, 6, 5, 6, 2, 0, 3];
const mystery4 = [4, 9, 2, 9, 8, 7, 7, 1, 6, 9, 2, 1, 7, 0, 9, 3];
const mystery5 = [4, 9, 1, 3, 5, 4, 0, 4, 6, 3, 0, 7, 2, 5, 2, 3];

// An array of all the arrays above
const batch = [valid1, valid2, valid3, valid4, valid5, invalid1, invalid2, invalid3, invalid4, invalid5, mystery1, mystery2, mystery3, mystery4, mystery5];


//The Luhn Formula
const validateCred = arr => {
    let cardNum = 0                                
    let revArr = arr.reverse()         
    
    for (let i = 0; i < revArr.length; i++){       
        let calcNum = revArr[i]                    
       if (i%2 !== 0){                          
                                           
                                           
        calcNum = revArr[i] * 2
            if (calcNum > 9){
                calcNum = calcNum - 9;
                cardNum += calcNum
            } else {
                cardNum += calcNum
            }
       } else {
        cardNum += revArr[i]
       }
    }
    return(cardNum%10 === 0 ? true : false)
}
//console.log(validateCred(valid1))

let findInvalidCards = invCard => {
    let newArr = []
        for (let i = 0; i < invCard.length; i++) {
            for (let x = 0; x < invCard[i].length; x++){
                newArr.push(invCard[i],[x]) 
            }
            console.log(validateCred(newArr[i]))
    }  
        
    }


(findInvalidCards(batch))

[stx182]

So basicly i had to delete the second for loop because i loop with the first for loop trough the array and with the validateCred function over the nested arrays. And i had to create a new variable that takes in the product of the first for loop.

And in the if statement i needed to set a parameter for the validateCred function which is in this case the new created variable. It makes so much sense now

I just tought it too complicated

let findInvalidCards = invCard => {
    let newArr = []

    for (let i = 0; i < invCard.length; i++) {
        let falseNum = invCard[i]
        if((validateCred(falseNum) === false)){
            newArr.push(invCard[i])
        }
    }  
    return (newArr)
}
        
    


console.log(findInvalidCards(batch))

[mtf]

There is no mutation of the array so a read-only loop will make things a bit easier:

    for (let x of invCard) {
        if (! validateCred(x)) {
            newArr.push(x)
        }
    } 

Aside

One generally avoids equating to false. The NOT will toggle false to true, and true to false.

[stx182]

this is very nice, Thank you!