Compliment Generator

[jennyseal]

• It was quite an easy exercise but I enjoyed it. It was good to put the GitHub learning into practice.
• It took about 90 minutes to make but that’s because I created an HTML and CSS file to display the compliments (scope creep!)
• This is the link: GitHub - JennySeal/ComplimentGenerator: Gives Randomised Compliments Just For You which has the HTML and CSS.

const introText = ['You are', 'You look', 'I think you are', 'Wow! You are', "It's true. You are", 'Can I say you look', 'You are always so']
const intensifier = ['mighty', 'so', 'very', 'really', 'extremely', 'most', 'truly', 'really very', 'absolutely']
const adjective = ['beautiful', 'glamourous', 'attractive', 'intelligent', 'amazing', 'fabulous',
'out of this world', 'glorious', 'awesome', 'delightful', 'pleasing', 'impressive']

const randomiser = (arrayParam) => {
    index = Math.random(arrayParam)*arrayParam.length;
    index = Math.floor(index);
    let compPart = arrayParam[index]
    return compPart;
}

const complimentGenerator = (introText, intensifier, adjective) => {
let intro = randomiser(introText)
let intense = randomiser(intensifier)
let descriptor = randomiser(adjective)
let compliment = `${intro} ${intense} ${descriptor}!`
writeCompliment(compliment)
}

const writeCompliment = (compliment) => {
document.getElementById('compliment').innerHTML = compliment;
document.getElementById('compliment').style.display = "block";
}

Any feedback would be lovely.

[stetim94]

Here:

    index = Math.random(arrayParam)*arrayParam.length;
    index = Math.floor(index);

I would this very likely make this one line, and use let for the index variable. Without let, the variable becomes global, unnecessary polluting the global namespace

given the security consideration:

Element.innerHTML - Web APIs | MDN

i would use textContent (and not innerHTML)

[jennyseal]

Great, thank you. That’s really helpful. I will make those changes.