Compare function error


#1

https://www.codecademy.com/courses/javascript-beginner-en-Bthev-mskY8/1/1?curriculum_id=506324b3a7dffd00020bf661#

I wrote the below code, it works properly, the compare function does return "The result is a tie" when there is actually a tie, but the Codeacademy platform keeps giving me an error saying that, "Oops, try again. Your compare function does not return 'The result is a tie!' when there is a tie."

am I missing something in my code or is the Codeacademy platform buggy?

Also, just a suggestion, the instructions for each section could be a little clearer when it comes to what we are supposed to do for each task. It instructs as if all you have to do in this section is create the function but doesn't mention the additional if, else if, else code needed.

Thanks.

var computerChoice = Math.random();

if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2){
    if(choice1 === choice2){
        return "The result is a tie";
    }else if(choice1 === "scissors"){
        if(choice2 === "rock"){
         return "rock wins";   
        }else{
         return "scissors wins";   
        }
    }else if(choice1 === "rock"){
        if(choice2 === "scissors"){
         return "rock wins";   
        }else{
         return "paper wins";   
        }
    }else if(choice1 === "paper"){
       if(choice2 === rock){
           return "paper wins"
       }else{
        return "scissors wins"   
       }
    }
      
};

compare(userChoice, computerChoice);


#2

Add the exclamation point. You have to use the exact text strings given in the instructions.


#3

Good to know. That fixed it. Thanks.


#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.