Code Review: Challenge Project: Flashcards

Projects Skill Path Projects
, ,
1

Hello,

I would like a code review for my code for the Flashcards Challenge Project that you can view and clone from my Flashcards GitHub linked here.

A comprehensive and critical review of the full project would be great from project code to file structure to read me.
I look forward to reading your review.
I am keen to do a code review myself so if you are in need of a code review then please let me know. Whether it is for this project or any of the others required on the front end or full stack paths.

Thank you.

2

Hi, I looked at your code on github , I would suggest:
1 can be converted to app.js using react-router-dom v6
2 initialState: {
cards: {}
},
you can put the functions on top to make it more readable.
3 create a folder with redux logic and split card domains:
slice
action
store
etc for me it is better to read the logic when it is in one folder and not scattered around the project, because if you have 100 files and in each file to search for its logic, it will be problematic.
4 my opinion is already {Object.values(quizzes).map((quiz) => (

  • {quiz.name}


    • ))}
    such functions can be placed in utils.jsx for example or on top of the components so that there is less code in the markup because you just render the list here and that’s it.

    I like that you made a Routes object, good luck.