Code is correct but I'm picking up a strange error


I’m currently on 13.13 (“Not again!”) and I’ve managed to get it correct, but I notice that whenever I give an incorrect guess that is on the board, it still returns as “Oops, that’s not even in the ocean.”

Am I just not far enough in the exercise to have corrected this?


from random import randint

board = []

for x in range(0, 5):
  board.append(["O"] * 5)

def print_board(board):
  for row in board:
    print " ".join(row)


def random_row(board):
  return randint(0, len(board) - 1)

def random_col(board):
  return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

guess_row = int(raw_input("Guess Row: "))
guess_col = int(raw_input("Guess Col: "))

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
  print "Congratulations! You sank my battleship!"
  if guess_row != range(5) and guess_col != range(5):
    print "Oops, that's not even in the ocean."
  elif [guess_row][guess_col] == "X":
  	print "You guessed that one already."
    print "You missed my battleship"
    board[guess_row][guess_col] = "X"


This …

if guess_row != range(5) and guess_col != range(5):

… should be …

if guess_row not in range(5) or guess_col not in range(5):

Testing for equivalence or non-equivalence of an int to a range here will not work. An int is never equivalent to a range, even if it is within the range.


Solving my problems again, @appylpye. Thank you :slight_smile: