Can anybody tell me what is wrong with my Javasript RPS Code?


#1

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {computerChoice = "rock";}
else if(computerChoice <= 0.67)
{computerChoice = "paper";}
else {computerChoice = "scissors";}

console.log("Computer: " + computerChoice);

var compare = function (choice1,choice2)
{if (choice1 === choice2)
{
return "The result is a tie!";
}
else if (choice1 === "rock")
{
if(choice2 === "scissors")
{return "rock wins";}
else { return "scissors wins";}
}
else if (choice1 === "paper")
{
if (choice2 === "rock")
{
return "paper Wins"
}
else if
{
return "rock wins"
}
}

else if (choice1 === "scissors") 
 {
    if (choice2 === "paper")
    {
        return "scissors wins"
    }
else
{ 
    return "paper wins"
} 
}

}

compare (userChoice,computerChoice);


#2

Please read
http://www.codecademy.com/forum_questions/559dcb4be39efe550f00006b
and concentrate on

  • required return-strings
  • the build of the IF ELSE-IF statement structure