Calling choice1 and choice 2 as userChoice and computerChoice, doesnt work


#1


https://www.codecademy.com/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#


syntax error: unexpected token


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);*/

var compare=function (choice1, choice2) {
    var choice1=userChoice;
    var choice2=computerChoice;
       if (choice1 === choice2){
        return "The result is a tie!";}
        
        else if (choice1==="rock") {
        if (choice2==="scissors") {
            return "rock wins";} else {
                return "paper wins";};
        }
        else if (choice1==="paper") {
            if (choice2==="rock") {
                return "paper wins";} else {
                    return "scissors wins";};
        }
        else if (choice1==="scissors") {
            if (choice2="rock") {
                return "rock wins";} else {
                    return "scissors wins";};
        };
                    
        
}


#2

no need for these variables here,

Remove the colons after the brackets in your else if blocks,

You only require one after your last bracket :slight_smile:


#3

sorry but it is not the reason.

1- computer chooses always what i choose
2- After the line: return, it does not appear, so the result of the game is not reflected on the screen
3- how does the computer know choice1= userchoice, choice2= computerchoice, if i dont define it?


#4

You also have a typo here,

Remove the */ at the end


#5

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.