Build "Rock, Paper, Scissors" Error


#1

I don't get my error. Help, plz!
https://www.codecademy.com/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#


Oops, try again. Your code returned 'scissors wins' instead of 'undefined' when the inputs are scissors and rock


var compare = function(choice1,choice2) {
if (choice1 === choice2) {
return "The result is a tie!";
} else
if (choice1 === "rock") {
if (choice2 === "scissors"){
return "rock wins";
} else
return "paper wins";
};
if (choice1 === "paper") {
    if (choice2 === "rock") {
        return "paper wins";
    } else 
return "scissors wins";
};
if (choice2 === "rock") {
    if (choice2 === "paper"){
        return "rock wins";
    } else
    return "scissors wins";
};
};
var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} 
console.log("Computer: " + computerChoice)
console.log("Your choice: " + userChoice);

#2

First of all, you cant use more than 2 "if" consecutive, try to use "else if".

I have to say that it's strange to see a very long code inside the "tie".. and you have several mistakes, for eg. you compare choice2 with choice 2:

or, you have to take into account that the winner has to be choice1 or choice2:

Look again your code. I'd recommend you to follow the course more carefully. Good luck :slight_smile:


#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.