Build library - Step 25 addRating - making sure input is between 1 and 5

Web Development
1

Hi all,

I’m struggling for a long time to find the code with the use of Math.min() and Math.max() on this step. For now, I managed to get the result using an if statement, but I would really love to understand how to do using this instead. I’ve been searching the internet for a long time now, but I can’t seem to find a definite solution. Could someone help me with it? I’m supposed to use it using spread syntax and I found this formula but I can’t seem to make it work:

function getMaxOfArray(numArray) {
  return Math.max.apply(null, numArray);
}

This is how I made step 25 work for now using an If statement (In .addRating() , make sure input is between 1 and 5):

 addRating(value){
    if(value < 1 || value > 5) {
      console.log('Error! Please rate between 1 and 5')
    } else {
      this.ratings.push(value);
    }
  }
2

Have you checked MDN Web Docs? If you don’t know what it is, it’s basically a programming Wikipedia.

3

Hi,

yes I did. That’s where the function example comes from…

4

Anybody? It would really help me to understand it :grinning:

5

Hi @jesveedee,
I think I’ve understood what you’re after, which is the following:

function inRange(value) {
value = Math.min(value, 5);
value = Math.max(value, 1);
return value; }

inRange(7);
// returns 5

inRange(-1);
// returns 1

inRange(3);
//returns 3

I haven’t used either of these functions before but what seems a bit counterintuitive to me is that you use Math.min() to create an upper bound (i.e., the function takes the lower of the two input values) and Math.max() to create a lower bound. From MDN:

Math.min() is often used to clip a value so that it is always less than or equal to a boundary.

Does that answer your question?

Edit: I just realised you can do the following, which is a bit more graceful:

function inRange(value) {
let cappedValue = Math.max(Math.min(value, 5), 1);
return cappedValue; }

But it’s a bit more obvious how the first one actually works.

1 Like
6

Hi @jonrosk089,

Thanks a lot for this! Now I get a better understanding of how to implement this.

This is what Codecademy would like you to use, but it doesn’t do anything in the results. With my if statement I will get an error if the number isn’t between 1 and 5 which is the assignment.

Thanks again!

1 Like
8

Hey. After also struggling for a while with this I got to this possible solution:

 addRating (newRating) {
    this._ratings.push(newRating);

    if (newRating >= 1 && newRating <= 5) {
      console.log('Thanks for rating!');
    } else {
      console.log('Try again. Your rate has to be between 1 and 5.');
    }
  }
}

Thought sharing here was valid because it’s a different approach. Instead of correcting the input with the code I thought of giving feedback to the imaginary human user.

Also, first time posting here. So appologies if this is not relevant or was somehow made the wrong way.

9

Hi all, I have just found a different solution using an if statement and rounding up the average rating to 1 decimal point.
Any feedback on this?

  addRating(value) {
      //this.ratings.push(value);
      Math.round(value, 2);
      if (value < 0 || value > 5) {
        return false
      } else {this.ratings.push(value)}
  }

I could not get the math.min method to work in any ways… I would like to understand better how and where to create that type of function