Battleships not updating O to X when inccorrect


#1

I’m think I’m getting the correct list to update the X but when I’ve got an answer wrong none of my zeros change. I know I’m not trying to append it since I don’t want X adding on but nothing updates.

Pretty sure my indents are correct (checking in Sublime).


board = []

for x in range(0, 5):
  board.append(["O"] * 5)

def print_board(board):
  for row in board:
    print " ".join(row)

print_board(board)

def random_row(board):
  return randint(0, len(board) - 1)

def random_col(board):
  return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

guess_row = int(raw_input("Guess Row: "))
guess_col = int(raw_input("Guess Col: "))

# Write your code below!
if guess_col == ship_col and guess_row == ship_row:
  print "Congratulations! You sank my battleship!"
else:
  print "You missed my battleship!"
  for wrong in board[guess_col][guess_row]:
    board[wrong] = "X"

#2

why you need a loop? You just need to update a single coordinate on the board. Loop are useful when having to do something multiple times, which isn’t the case here


#3

How are you measuring that? I don’t see any code printing out the board after that happens.
If anything, from reading your code, I would expect a crash.

You’ve got some particular addressing system, there’s a column and a row involved. Where should the change happen, and where does it happen?


#4

Oh god, I was staring at it all lunchtime.

You (obviously) were correct I forgot to print the resulting grid with the X in it.