BattleShip Test Run!


#1

This is my code

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == guess_col:
    print "Congratulations! You sank my battleship!"
elif board[guess_row][guess_col] == "X":
    print "You guessed that one already."
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"

If I try out of range, I get an error intead of my message:

Traceback (most recent call last):
  File "python", line 31, in <module>
IndexError: list index out of range

#2

Guys, please someone give me some feedback?


#3

Please always format your code. Thanks! - discuss.codecademy.com/t/using-backticks-to-format-your-code/3697

if guess_row not in range(5) or guess_col not in range(5):

this is the condition for checking if the index is out of bounds of the board list and this should be before the statement:

elif board[guess_row][guess_col] == "X":

Can you guess why? (note that you get an error on the very above line, when the input exceeds the bounds)

Refer this thread for further discussion on same error