Battleship: Test Run Bugs


the range() function in python counts from 0 up to the index included in parentheses, that means range(5) counts out [0, 1, 2 , 3, 4]

This is causing an issue with my battleship program because now whenever I enter the number 5 into the console as a guess I get my "Oops, that’s not even in the ocean message.

Any fixes? even when I change all three ranges to 6 it changes nothing.

from random import randint

board = []

for x in range(5):
  board.append(["O"] * 5)

def print_board(board):
  for row in board:
    print " ".join(row)


def random_row(board):
  return randint(0, len(board) - 1)

def random_col(board):
  return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col
guess_row = int(raw_input("Guess Row: "))
guess_col = int(raw_input("Guess Col: "))

if guess_row == ship_row and guess_col == ship_col:
  print "Congratulations! You sank my battleship!"   
  if guess_row not in range(5) or \
    guess_col not in range(5):
    print "Oops, that's not even in the ocean."
  elif (board[guess_row][guess_col] == 'X'):
    print "You guessed that one already."
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"


what you want to do (i assume) is to let the user enter 1-5?

So, you are working in python, what is easier to manipulates? Python lists, or the user input?

See if you can find a way to manipulate the user input so 1-5 match 0-4


That worked, added

guess_row = int(raw_input("Guess Row: ")) - 1
guess_col = int(raw_input("Guess Col: ")) - 1

now my answers format to 0-4

thanks a lot, great answer made me think of the best solution rather than being told, appreciate the great support