Battleship! Real AIM


#1



Real Aim


it display's "break outside loop".
Please help me out!


 
from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

for turn in range(4):
    turn=turn+1
    final()
def final(): #function to repeat the game
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
        break
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif (board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col]="X"
            if turn==4:
                print "Game Over"
        print_board(board)
for turn in range(4):
    turn=turn+1
    final()


#2

It's "break" on line 34 that is causing the issue. Try deleting it.

I went through the code and fixed some issues. I'm not 100% sure it works as you intend it to work, but it is at least running. Here is the code I edited:

import sys

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)


def print_board(board):
    for row in board:
        print(" ".join(row))


print("Let's play Battleship!")

print_board(board)


def random_row(board):
    return randint(0, len(board) - 1)


def random_col(board):
    return randint(0, len(board[0]) - 1)


ship_row = random_row(board)
ship_col = random_col(board)
print(ship_row + 1)
print(ship_col + 1)


def final():  # function to repeat the game
    guess_row = int(input("Guess Row:")) - 1
    guess_col = int(input("Guess Col:")) - 1
    if guess_row == ship_row and guess_col == ship_col:
        print("Congratulations! You sunk my battleship!")
        sys.exit()
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print("Oops, that's not even in the ocean.")

        elif board[guess_row][guess_col] == "X":
            print("You guessed that one already.")

        else:
            print("You missed my battleship!")

            board[guess_row][guess_col] = "X"
            if turn == 4:
                print("Game Over")

        print_board(board)


for turn in range(4):
    turn += 1
    final()

#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.