Battleship -- Oops, try again. Make sure you print "Oops, that's not even in the ocean." if the user guesses a row or column that is off the board--Resolved


#1

https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/3?curriculum_id=4f89dab3d788890003000096#

I am getting following error message :-
Oops, try again. Make sure you print "Oops, that's not even in the ocean." if the user guesses a row or column that is off the board.


How Do I get rid of this error message?


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)

print ship_row
print ship_col

guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))


# Write your code below!
if guess_row==ship_row and guess_col==ship_col :
    print "Congratulations!You sank my battleship!"
    board[ship_row][ship_col]="X"
else :
    if guess_row not in range(len(board)+1) \
    or guess_col not in range(len(board)+1) :
       print "Oops,that's not even in the ocean."
        
    else :
       print  "You missed my battleship!"
       board[ship_row][ship_col]="X"

print_board(board)


#2

from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

Write your code below!

if guess_row==ship_row and guess_col==ship_col:
print "Congratulations! You sank my battleship!"
else:
print "You missed my battleship!"
if guess_row not in range(5) or guess_col not in range(5):
print "Oops, that's not even in the ocean."
else:
board[guess_row][guess_col] = "X"
print_board(board)

this is my code and it works


#3

You need to put a space between the comma, and "that's"


#4

print "Oops,that's not even in the ocean." needs a space and

i am not sure but i think this is extra board[ship_row][ship_col]="X" under print "Congratulations!You sank my battleship!"

sorry in advance if i am wrong


#5

their might be more .......


#6

Thanks Guys .This is what was causing
"Oops,that's not even in the ocean." -- the one with space missing after comma
"Oops, that's not even in the ocean." --- by adding space after comma my code worked


#7

welcome ............