Battleship 14. Test Run


#1


https://www.codecademy.com/en/courses/python-beginner-en-4XuFm/1/5?curriculum_id=4f89dab3d788890003000096


When I guess correctly, I either win or get a "You missed my battleship!" and an "X" is placed where I guessed. Then the lesson says it's complete and allows move on to the next lesson.

When I guess out of range, I get a pop-up that says "Oops, try again. Your code looks a bit off. Feel free to peek back at earlier exercises if you need help! Your code threw teh following error: list index out of range" The view shows the error 'Traceback (most recent call last):
File "python", line 33, in
IndexError: list index out of range"


I expected to see:
"You missed my battleship!" and
"Oops, that's not even in the ocean."

I'm not sure why this is only working half the time. For the record, line 33 is:
board[guess_row][guess_col] == "X"


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else: 
    print "You missed my battleship!"
    board[guess_row][guess_col] == "X"
    print print_board(board)

    if guess_row not in range(5) or  guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    elif board[guess_row][guess_col] == "X":
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print print_board(board)


#2

After the Win case, the next check should be range.


#3

this should be the structure:

if hit:
  
# handles incorrect guesses
else:
    # different cases for incorrect guesses
   if not on board:
   elif already guessed
   else:

you have code between your else for incorrect guesses and the if not on board


#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.


#5

#6