Bad Aim


#1



https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/3?curriculum_id=4f89dab3d788890003000096#

O O O O O
O O O O O
O O O O O
O O O O O
O O O O O
Guess Row: 6
Guess Col: 6
4
4
Outside the range
None
Oops, try again. Make sure you print "Oops, that's not even in the ocean." if the user guesses a row or column that is off the board.


The website claims this code is correct, but according to other forum posts this is far from being so. Could I have some help as to what I am doing wrong?

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    
    if guess_row is not range(5) or guess_col is not range(5):
        print "Oops, that's not even in the ocean"
    else: 
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print_board(board)


#2

not in range(5), why would you use the is keyword?


#3

Mistake, didn't use that on purpose.

Now, the is has been changed to in. I am now getting the error "invalid syntax"
from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

Write your code below!

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
else:

if guess_row in not range(5) or guess_col is not range(5):
    print "Oops, that's not even in the ocean."
else: 
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)

#4

not in, i don't think you can do in not


#5

...goddammit...

Okay, now I have replaced in not and is not with not in, but the board is still not printing with "X" marking the battleship.

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else: 
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print_board(board)

O O O O O
O O O O O
O O O O O
O O O O O
O O O O O
Guess Row: 6
Guess Col: 6
3
4
Oops, that's not even in the ocean.
None


#6

if you enter coordinates which are not on the board, the if not in range runs, the board doesn't get updated, that only happens when you enter valid coordinates


#7

Right, my mistake. Thank you all the same.


#8

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.