Bad Aim


#1

Is there something wrong with this code?

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == random_row(board) and guess_col == random_col(board)and guess_row in range(5) and guess_col in range(5):
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)
if guess_row not in range(5) or guess_col not in range(5):
    print "Oops,that's not even in the ocean!"
    print_board(board)
else:
    print"You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)

Link to the exercise : https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/3?curriculum_id=4f89dab3d788890003000096#
The error i keep getting : "Traceback (most recent call last):
File "python", line 33, in
IndexError: list index out of range"


#2

I'm not entirely certain because I'm also having trouble on this, but your second IF statement needs to be nested inside the previous ELSE statement. I also don't think you need to repeat the "You missed..." again.
I'm pretty sure it needs to be something like this:

if:
    print "congrats.."
else:
    if:
        print "oops..."
    else:
        print "missed..."

I could also be completely wrong, since mines not working correctly either lol :blush:


#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.