Bad Aim | Problem


#1

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)

    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, thats not even in the ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
print_board(board)

Can anyone help me with this ?


#2

if you enter invalid coordinates, this line:

board[guess_row][guess_col] = "X"

causes a problem, given you try to access indexes in a list, but this indexes are out of range, the if not in range should come before this


#3

could you clarify by what you mean by this


#4

Nvm I got it, didn't read your answer properly.
Cheers