# Bad Aim - List Index Out of Range

#1

Bad Aim

When I run this code within the range of 5 it works fine.
If I run it outside of that range, it fails with the following:

``````Traceback (most recent call last):
File "python", line 28, in <module>
IndexError: list index out of range``````

Out of interest, line 28 is:
`board[guess_row][guess_col] = "X"`

I thought it would say "That's not even in our ocean!"

``````from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

board[guess_row][guess_col] = "X"

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
print_board(board)
else:
if guess_row not in range(5) or guess_col not in range(5):
print "That's not even in our ocean!"
else:
print "You missed my battleship!"
print_board(board)``````

#2

it would, but a program execute in order (from top to bottom) and this line:

``board[guess_row][guess_col] = "X"``

is far before you check if the shot is even in the ocean, you might to add this here:

``````else:
// add missed shot here
print "You missed my battleship!"
print_board(board)``````

#3

Then I see the following:

Traceback (most recent call last):
File "python", line 31, in
IndexError: list index out of range

#4

please make your own topic with your full code, so someone can actually help you, rather then posting this reply which is not really helpful

#5

Perfect thank you!
It took me a while to realise why there, but then, we're simply showing the X (where they tried) and that's where that logic is run. Perfectly done, thanks again.

#6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.