Ahhhhhhh help


#1



bad aim

i dont know what is wrong with this it comes up with the error message:

Traceback (most recent call last):
File "python", line 34, in
IndexError: list index out of range

it should work please tell me why it doesnt


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!

if guess_row == ship_row and guess_col == ship_col:
    print("Congratulations! You sank my battleship!")
else:
    print ("You missed my battleship!")
    board[guess_row][guess_col] = "X"
    print_board(board)
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col]="X"
        print_board(board)


#2

you have this code:

    print ("You missed my battleship!")
    board[guess_row][guess_col] = "X"
    print_board(board)

twice, why? By having this code before you validate the shot is in the ocean, you can still have an index error


#3

im not sure why i put it twice ill have another look and remove it


#4

ok so i removed the repeated line of code but it is still throwing up an error message:

Oops, try again. Make sure you print "Oops, that's not even in the ocean." if the user guesses a row or column that is off the board.

but my code looks the same like this:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col]="X"
        print_board(board)

#5

you print:

"Oops, that's not even in ocean."

you should print:

"Oops, that's not even in the ocean."

you miss the


#6

ohhh thank you for helping


#7