A real win


#1

would you tell me what's wrong with this code? its says SyntaxError: 'break' outside loop.

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
    # Print (turn + 1) here!
        for turn in range(4):
            print "Turn", turn + 1
            guess_row = int(raw_input("Guess Row:"))
            guess_col = int(raw_input("Guess Col:"))
        if turn == 3:
            print "Game Over"
            
    print_board(board)

Real win
#2

see these comments:

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!

that is where your loop should start. Your loop starts to late


#3

seriously i' don't get it. would you please show me where the "break" must be place it


#4

the placing of the break is fine, but your loop:

for turn in range(4):

should start after the comments (see first post), your loop start way later (too late)


#5

i'm sorry i still don't get it.i've reset the code then i follow the hint: Your break should go inside your if statement, right after your "Congratulations!" message.


#6

the break the right place, the loop is not:

# your loop should be here
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
    # Print (turn + 1) here!
        for turn in range(4):
            # your loop starts here, far too late
            print "Turn", turn + 1
            guess_row = int(raw_input("Guess Row:"))
            guess_col = int(raw_input("Guess Col:"))
        if turn == 3:
            print "Game Over"
            
    print_board(board)

see comments, your loop starts to late.


#7

thank its solved after i looked at your answer in other post. :+1:


#8