A Real Win 17/19


#1



from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
for turn in range(4):
    print "Turn", turn + 1


guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
break
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        if turn == 3:
            print "Game Over"
    # Print (turn + 1) here!
    print_board(board)


#2

What is your question?


#3

Sorry about that, my question was what is wrong with my code? I keep receiving this error
File "python", line 38
else:
^
SyntaxError: invalid syntax
I basically want to know what I've done wrong and how I can fix it


#4

these 4 lines:

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
break
else:

the break should be inside the if statement (re-indent it)


#5

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sunk my battleship!"
break
File "python", line 37
SyntaxError: 'break' outside loop
I've tried that but I get this error instead


#6

all this code:

guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
break
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        if turn == 3:
            print "Game Over"
    # Print (turn + 1) here!
    print_board(board)

should be in your for loop:

for turn in range(4):
    print "Turn", turn + 1

you made a comment about it, and yet you didn't do this


#7

It worked :smiley: thank you so much! Sorry for sounding rude


#8

Hello,
I've received an error message that my syntax is off on line 36, but I don't understand why. Any advice would be appreciated.


#9

a else always has to come after a if or a elif:

if condition:
   // do something if true
else:
  // do something else

in your case, break is at the same indention level as else, re-indent break. Speaking of indention, take a look at your whole indention, it is off