A little help with my code maybe?


#1


https://www.codecademy.com/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#


SyntaxError: Unexpected token else


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1,choice2) {

if(choice1===choice2) {
    return "The result is a tie!";    
    }
    
else if (choice1==="rock") {
    
    if (choice2==="scissors") {
        return "rock wins";
      }
       else {
         return "paper wins" ;
      }
    }
   
  else if (choice1 === "paper") {
      if (choice2 === "rock") {
           return("paper wins");
          }
      else {
           return("scissors win");
          }
   else if (choice1 === "scissors") {
       
       if (choice2 === "paper") {
           return("scissors win");
          }
      else {
           return("scissors win");
          }
};
  
  console.log( compare(userChoice,computerChoice) );

Am stuck with this exercise for a while and I can't seem to figure out what's wrong with it!


#2

   else if (choice1 === "paper") 
   {
      if (choice2 === "rock") 
      {
         return("paper wins");
      }
      else 
      {
         return("scissors win");
      } 
   // you didnt close your else if
   else if (choice1 === "scissors")  
   {
       
       if (choice2 === "paper") 
       {
           return("scissors win");
       }
       else 
       {
           return("scissors win");
       }
    // you didnt close your else if

};

#3

Thanks for Help, I closed my else if and the same problem persists!


#4

I think you didnt find all closing bracets and in your last else if was a mistake scissors wins instead of rock

var compare = function(choice1,choice2) {
    if(choice1===choice2) {
        return "The result is a tie!";    
    } else if (choice1==="rock") {
        if (choice2==="scissors") {
            return "rock wins";
        } else {
            return "paper wins" ;
        }
    } else if (choice1 === "paper") {
        if (choice2 === "rock") {
           return("paper wins");
        } else {
           return("scissors win");
        }
    } else if (choice1 === "scissors") {
        if (choice2 === "paper") {
           return("scissors win");
        }
        else {
           return("rock win");
        }
    }
 };
 console.log( compare(userChoice,computerChoice) );

This works


#5

Thanks a lot!

It totally worked :slight_smile:


#6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.