8. What if choice1 were scissors


#1

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2) {
if(choice1 === choice2) {
return "The result is a tie!";
} else if (choice2 === "rock") {
if(choice2 === "scissors") {
return "rock wins";
} else {
return "paper wins";
}
} else if (choice1 === "paper") {
if(choice2 === "rock") {
return "paper wins";
} else {
return "scissors wins";
}

} else if(choice1 === "scissors") {
    if(choice2 === "rock"){
     return "rock wins";   
    } else {
        return "scissors wins";
    }
}

};
console.log (compare(userChoice,computerChoice));

No idea whats wrong, error message "Your code returned 'paper wins' instead of 'undefined' when the inputs are scissors and rock"


#3

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice <= 0.34) {
  computerChoice = "rock";
} else if (computerChoice <= 0.67) {
  computerChoice = "paper";
} else {
  computerChoice = "scissors";
}
console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2) {
  if (choice1 === choice2) {
    return "The result is a tie!";
  } else if (choice1 === "rock") { //This was checking if choice2 === "rock"
    if (choice2 === "scissors") { 
      return "rock wins";
    } else {
      return "paper wins";
    }
  } else if (choice1 === "paper") {
    if (choice2 === "rock") {
      return "paper wins";
    } else {
      return "scissors wins";
    }

  } else if (choice1 === "scissors") {
    if (choice2 === "rock") {
      return "rock wins";
    } else {
      return "scissors wins";
    }
  }

};
console.log(compare(userChoice, computerChoice));

#4

here the else if questions choice2 where it should look at choice1.


#5

That did it, thank you for the help.


#6

A post was split to a new topic: Did you set var computerChoice = Math.random() ? The capital 'M' in 'Math' is important!