8. What if choice1 is scissors?


#1

Need helpwith this code, getting "Oops, try again. Your code returned 'paper wins.' instead of 'undefined' when the inputs are scissors and rock"

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2){

if(choice1 === choice2){
    return "The result is a tie!";}
    
    else if(choice1 === "rock"){

}
if(choice2 === "scissors"){
return "scissors wins";}

    if(choice1 === "paper"){
        return "paper";}

        else if(choice2==="rock"){
            return "paper wins.";}

            else {
                return "sissors wins!";}

       if(choice1 === "scissors"){
           return "scissors";}

       else if(choice2==="rock"){
            return "rock wins.";}

            else{
                return "scissors wins!";
            }

};


#2

I figured out what 'leave undefined' meant!

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2){

if(choice1 === choice2){
    return "The result is a tie!";}
    
    else if(choice1 === "rock"){

}
if(choice2 === "scissors"){
return "scissors wins!";}

    if(choice1 === "paper"){
        return "paper";}

        else if(choice2==="rock"){
        }

            else {
                return "scissors wins!";}

       if(choice1 === "scissors"){
       }

       else if(choice2==="rock"){
            return "rock wins.";}

            else{
                return "scissors wins!";
            }

};


#3

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2){
if (choice1 === choice2){
return "The result is a tie!";
}
else if(choice1 === "rock"){
if(choice2 === "scissors"){
return "rock wins";
}
}
else if(choice1 === "paper"){

if(choice2 === "rock"){
    return "paper wins";
}
} else{
 return "scissors wins";   
}
else if(choice1 === "scissors"){
 if(choice2 === "rock"){
  return "rock wins";   
 } else{
 return "scissors wins";   
}
}

}
console.log(compare(userChoice, computerChoice));

can you help me out?


#4

change your choice1 to userChoice and choice2 to computerChoice too in your compare Function

var compare = function(userChoice, computerChoice) 
if (..){...}
else if (..){...}
else {...}

#6

This topic is solved.