8.What if choice1 is scissors? oops try again error


#1



https://www.codecademy.com/en/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661


I get this error message and I don't know what to do.
Oops, try again.
Your code returned 'The result is a tie!' instead of 'undefined' when the inputs are scissors and rock


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if(computerChoice < 0.34) {
    computerChoice = "rock";
} else if(computerChoice <= 0.67) {
    computerChoice = "paper";
} else {
    computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2) {
    
    if(userChoice === computerChoice) {
        return "The result is a tie!";
    } 
    else if(choice1 === "rock") {
        if(choice2 === "scissors") {
            return "rock wins"
        } 
        else {
            return "paper wins"
        }
    } 
    else if(choice1 === "paper") {
        if(choice2 === "rock") {
            return "paper wins"
        } 
        else {
            return "scissors wins"
        }
    } 
    else if(choice1 === "scissors") {
        if(choice2 === "paper") {
            return "scissors wins"
        } 
        else {
            return "rock wins"
        }
    }
};
compare(userChoice, computerChoice);


#2

If I pick rock and the computer picks rock the error says;
"Oops, try again. Your code returned 'The result is a tie!' instead of 'undefined' when the inputs are scissors and rock"

If I pick rock and the computer picks paper the error says;
"Oops, try again. Your code returned 'rock wins' instead of 'undefined' when the inputs are scissors and scissors"

If I pick rock and the computer picks scissors the error says;
"Oops, try again. Your code returned 'rock wins' instead of 'undefined' when the inputs are scissors and scissors"

I don't know if I should do it for all of them but that's the gist of it. It does it for all of them I think.


#3

Hi I am not sure but do you want to try
if(choice1 === choice2) {
return "The result is a tie!";
}
instead of what you are doing now, which is
if(userChoice === computerChoice) {
return "The result is a tie!";
}


#4

:smiley: Many Thanks. This fixed it. Such simple problems cause all this trouble.