8. What if choice1 is scissors? HELP


#1

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
}
console.log("Computer: " + computerChoice);
console.log("You: " + userChoice);

var compare = function (choice1, choice2) {
    if (choice1 === choice2) { 
       return("The result is a tie!");
    } else if (choice1 === "rock") {
                if (choice2 === "scissors") {
                    return"rock wins";
                } else {
                    return "paper wins";
                }
            } else if (choice1 === "paper") { 
                        if (choice2 === "rock") { 
                            return "paper wins";
                        } else {
                            return "scissors wins";
                        }
                    } else if(choice1 === "scissors") {
                                if(choice2 === "paper") {
                                    return "scissors wins";
                                } else {
                                    return "paper wins";
                                }
                            }
}

console.log(compare(userChoice, computerChoice));

error its giving me: Oops! try again. Your code returned 'paper wins' instead of 'undefined' when the inputs are scissors and rock.

but the game works...

please advise what is wrong with my code :frowning:


#2

Well if the inputs are "scissors" and "rock" the output should definitely not be "paper wins". I guess the assumption of undefined is that the test function either expects that this case is not yet created: undefined or that it is the correct output but nothing else then these two options.

The problem is that you use "paper wins" in the else case instead of "rock wins". That is not a syntax error so your game works but it is a logic error it's against the game rules.


#3

Thank you!!!!
blame it on my woman logic :stuck_out_tongue:

Thanks for the quick reply