#8. What if choice one is scissors? Help!


#1

i cant figure out what is wrong with my code.. please help. i've been stuck on this for days.. thanks. my error is - there was a problem with your syntax.

var userChoice=prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function (choice1,choice2) {
if(choice1===choice2) {
return "The result is a tie!";
}
else if (choice1==="rock") {
if(choice2==="scissors") {
return "rock wins";
}
} else {
return "paper wins";
}
} else if (choice1==="paper"){
if (choice2==="rock") {
return "paper wins";
}
}
else {
return "scissors wins";
}
}
else if (choice1==="scissors") {
if (choice2==="rock"){
return "rock wins";
}
}
else {
return "scissors wins";
}
}
}
};
console.log (compare(userChoice, computerChoice));


#2

Hi @clee820

If it may help please see the code example below. It looks like you fell victim to the syntax gremlins on this one. In short you had one too many closing parens on you internal IF statements, if you remove those so that all parens correctly line up you should be ready to rock & paper & scissors :wink:

var userChoice=prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();

if (computerChoice < 0.34) {
    computerChoice = "rock";
} else if(computerChoice <= 0.67) {
    computerChoice = "paper";
} else {
    computerChoice = "scissors";
} 
console.log("Computer: " + computerChoice);

var compare = function (choice1,choice2) {
    if(choice1===choice2) {
        return "The result is a tie!";
    }
    else if (choice1==="rock") {
        if(choice2==="scissors") {
        return "rock wins";
    //} remove extra parens
        } 
        else {
            return "paper wins";
        }
    } 
    else if (choice1==="paper") {
        if (choice2==="rock") {
            return "paper wins";
        //} remove extra parens
        }
        else {
            return "scissors wins";
        }
    }
    else if (choice1==="scissors") {
        if (choice2==="rock"){
            return "rock wins";
        //} remove extra parens
        }
        else {
            return "scissors wins";
        }
    //} remove extra parens}
    }
};
console.log (compare(userChoice, computerChoice));

You will see that I indented your code for my example, although this is defintly a choice of preference it does help with being able to spot the odd gremlin :smile: