8/9 What if choice1 is scissors?


#1

Hi, my code works, the game is functioning, but i keep getting this message:
'Oops, try again. Your code returned 'scissors wins' instead of 'undefined' when the inputs are scissors and rock'
dont really understand, can someone help?

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2){
if (choice1 === choice2){
    return "The result is a tie!";
}
else if (choice1 === "rock")
{
    if(choice2 === "scissors")
    {
        return "rock wins";
    }
    else
    {
        return "paper wins";
    }
}
else{
    return "scissors wins";
    }
};
compare(userChoice,computerChoice);

#2

Do you mean it returns "Undefined" rather than "Scissors wins!"?


#3

you're missing the code for choice1="paper" and choice1="scissors"


#4

hi this part of your code

else if (choice1 === "rock")
{
    if(choice2 === "scissors")
    {
        return "rock wins";
    }
    else
    {
        return "paper wins";
    }
}
else{
    return "scissors wins";
    }
};

should have that structure

else if (condition) {
    if (condition) {

    }
    else {

    }

}
} <== //for closing the compare function

#5

2 posts were split to a new topic: Which problem in my code?