2.8 What if choice1 is scissors? with Oops, try again


#1


https://www.codecademy.com/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#


In terms of the userChoice and the computerChoice the game works really well, but I always get an "Oops, try again." with information that doesn't match what's printed.

For example:
userChoice = rock
computerChoice = rock
The result is a tie!
But then I get an error message saying "Oops, try again. Your code returns 'paper wins' instead of 'undefined' when the inputs are scissors and paper."

Here's my code:


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2) {
    if (choice1 === choice2) {
        return "The result is a tie!";
    } else if (choice1 === "rock") {
        if (choice2 === "scissors") {
            return "rock wins";
        } else {
            return "paper wins";
        }
    }  else if (choice1 === "paper") {
        if (choice2 === "rock") {
            return "paper wins";
        } else {
            return "scissors wins";
        }
    } else if (choice1 === "scissors") {
        if (choice2 === "rock") {
            return "rock wins";
        } else {
            return "paper wins";
        }
    }
};
console.log(compare(userChoice, computerChoice));

Any help is appreciated.


#2

Remove the console.log() so it should just be compare(userChoice,computerChoice)


#3

It didn't change anything, I still get the same error message.


#4

Yoir last else if might be the problem because of how you have evaluated the outcomes,

Should look like,

else if(choice1 === "scissors") {
    if(choice2 === "paper") {
        return "scissors wins";
    }
    else {
        return "rock wins";
    }
}
};

#5

I can't believe I didn't see that, thank you!


#6

You're welcome :slight_smile:


#8

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.