19/19 : Keep getting "This is not a number" even though an integer


#1

So i already completed the battleship and it says i passed, however when i run the program and enter a number
it keeps calling on the for loop that says “this is not a number”.

I’m stumped and can’t find problem.

Code Below:

from random import randint

board = []

for x in range(10):
  board.append(["O"] * 5)
#creates a board with 5 rows and columns of "O"
def print_board(board):
  for row in board:
    print " ".join(row)
#Joins the board with a space inbetween the "O"
print_board(board)

def random_row(board):
  return randint(0, len(board) )
#generates a random number between 0 and the length of the board
def random_col(board):
  return randint(0, len(board[0]))

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col


for turn in range(4):
  guess_row = int(raw_input("Guess Row: "))
  guess_col = int(raw_input("Guess Col: "))

  if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break
  else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
      print "Oops, that's not even in the ocean."
    if type (guess_row or guess_col) is not str:
      print "That isn't a number"
    elif(board[guess_row][guess_col] == "X"):
      print "You guessed that one already."
    else:
      print "You missed my battleship!"
      board[guess_row][guess_col] = "X"
    if turn == 3:
      print "Game Over"
    
  print (turn + 1) 
  		
  print_board(board)

#2

Hello :slight_smile:

if type (guess_row or guess_col) is not str:
  print "That isn't a number"

That does not look like a good way to check if value of variable is a number, right? type(2) is int, not str.


The left side of the condition is also incorrect. Please note that:

type("" or 2)
=> <type 'int'>

That is why you should explode this condition into two parts:

if type(guess_row) is not int or type(guess_col) is not int :
  print "That isn't a number"

#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.