18. To Your Battle Station!



Hi everyone, this is my code, that is running. But i would like to know if someone could help me making it even better. The things i would like to add are:

1. If the user gets out of the ocean or if select an selected row, column, dont consider it in the 4 turns
2. If you dont put any row or column number, dont break.

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)

for turn in range(4):
    # Everything from here on should go in your for loop!
    # Be sure to indent four spaces!
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))

    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
        if turn==3:
            print "Game Over"
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
    print "Turn", turn+1


Indent this so it is inside the last else block. That will prevent incrementing the turn counter in all cases except when "You missed..." .


Consider an approach with less nesting...

if __:

elif __:

elif __:

elif __:


Further hint at improvement:

elif guess_row not in range(5) or guess_col not in range(5):


you're so ■■■■ right! thank for the aclaration :slight_smile: !!