18 - Make it stahp!


#1

Okay, this is sort of a weird thing, but you see, I got this beautiful code here:

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

for turn in range(4):
    print "Turn ", turn + 1
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
        break
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
        if turn == 3:
            print "Game Over"
        print_board(board)

And it works great! The compiler likes it, I even tested it out on my own compiler and it runs, smoothly, yeah!

But, there's one problem: I can only input my coordinates once, and then it just iterates the same coordinates again and again without stopping until it's Game Over.

I bet I am missing something, and I bet it's something dumb, and it's just flying WAY over my head, but is there a way to, you know, make the game request another pair of coordinates, once again, so I can actually try playing it?

Thanks~


#2

agree with me that the iteration is done by the for loop? So if you want to re-prompt for each run of the loop, i would simply put the prompts inside the loop:

for turn in range(4):
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    print "Turn ", turn + 1

#3

Thank you so much, like I've said it'd be, it completely flew over my head that guess_row and guess_col would have to be in the loop as well.

Well, that's what happens when you code late at night.