18/18 To Your Battle Stations, It used to work, now something is wrong


#1

from random import randint

board = []

for x in range(5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)

Everything from here on should go in your for loop!

Be sure to indent four spaces!

for turn in range(4):
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] == "X"
    if turn == 3:
        print "Game Over"
    print "Turn", turn + 1
    print_board(board)

I get no errors, and the unit will still move on as if I have passed, but the board no longer prints out with an "X", where I guess. Can anyone sort out this issue? I really do not understand. Thank you in advance for the help!


#2

For those with a similar issue, I looked into previous exercises and found my own solution! Check below:

        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"

in the above code you will see that the "you missed my battleship!" portion of the if/else/elif statement had board[guess_row][guess_col] == "X"
the bold is what changed, I changed my code to read "=" instead of "==" and that fixed it. I still would like help understanding why this made it work though. If anyone can answer that I would be appreciative.


#3

= is used to save something to an object. So for example;

a = 5 #saves the number 5 into your variable a

== is used to check whether 2 things are the same or not and returns a boolean for the result. So for example;

a == 5 #checks if a is equal to 5. 
#If yes then a == 5 is True. If not then a == 5 is False.

#4

Thank you very much good sir or madam :smile: I found this very helpful.