17/19 "outside loop" problem!


#1



https://www.codecademy.com/en/courses/python-beginner-en-4XuFm/2/3?curriculum_id=4f89dab3d788890003000096#


Hey, my code isn't working. The error message is "Oops, try again. Your code looks a bit off. Check the Hint if you need help! Your code threw the following error: 'break' outside loop (python, line 36)" Moreover, there was a "this is all part of your for loop, indent four spaces" thing which I forgot until this exercise, and somehow I got through the exercises before this one without that as a problem. Is that part important?


I expected the "break" thing to work like it ought to


from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!

for turn in range(4):
    turn = turn + 1
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        if turn == 3:
            print "Game Over"
    print_board(board)
    
for turn in range(4):
    print "Turn", turn + 1

Could anyone please tell me what's wrong with my code here? Thanks so much!


#2

I think the issue may lie with your indentation. break should be within the if, and if should be within the for loop.

for turn in range(3):
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))
print_board(board)

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break

#3

I managed to make it work, but thanks for the advice! Besides, I still don't really know how I made it work :slight_smile:


#4

The only problem is your indentation. Your code should let players guess 4 times which means everything under turn+=1 should be inside the for loop. Here's how i would do it:


#5

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.