16. Game Over I need more explanation (Why my code doesn't print "game over"


#1

Hello, i've tried to modify a little the code, but it doesn't print "game over" as expected.

Here is my code :

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!

#ask user how many turn he wants to play
range_turn = int(raw_input("Turn "))


for turn in range(range_turn):
 #if no more turn left print game over
     if turn > range_turn :
        print "Game Over"
    else:
#ask user how many turn he wants to play
        guess_row = int(raw_input("Guess Row:"))
        guess_col = int(raw_input("Guess Col:"))
        guess_row -= 1
        guess_col -= 1
    
        
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
    else:
        if guess_row not in range(5) or guess_col not in range(5):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
    # Print (turn + 1) here!
        print "Turn", turn + 1
        print_board(board)

Thanks Buddys


#2

This for-loop will go throug the integers from 0 to (range_turn - 1). This means the loop will end before turn is bigger than range_turn and even before they are equal.

Maybe try to put the "Game over" part after the for-loop, or use a while-loop.


#3

You solved my problem ! thanks,

here comes the code :

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
range_turn = int(raw_input("Turn "))
for turn in range(range_turn):
    
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    guess_row -= 1
    guess_col -= 1
    
        
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
    else:
        if guess_row not in range(5) or guess_col not in range(5):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
    # Print (turn + 1) here!
        print "Turn", turn + 1
        print_board(board)
    if turn > range_turn -2:
        print "Game Over"

#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.