14. Test Run: Only getting to guess once


#1

I'm not getting an error in the sense that I can't pass the lesson, it's just that my game doesnt work properly. What do I need to add/change to get to guess more than once? Also, it prints "Oops, that's not in the ocean" regardless of what my guess is.

from random import randint

board = []

for x in range(0, 6):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row & guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
elif guess_row == 'X' and guess_col == 'X':
    print "You guessed that one already."
else:   
    print "You missed my battleship!"
    board[guess_row][guess_col]="X"
    print print_board(board)
    if guess_row not in range(5) or \
       guess_col not in range(5):
           print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col]="X"
        print print_board(board)

#2

At this point in the project are we expected to do more than a dry run? Extra guesses comes up in a later exercise, as I recall.

This looks incorrect, as well...

It should be written,

print_board(board)

and let the function do the printing.

On the range test question, I did a test and couldn't reproduce the error you report.

def check_guess(r,c):
    return r not in range(5) or c not in range(5)

guess_row = 4
guess_col = 5
if check_guess(guess_row, guess_col):
    print "Oops, that's not even in the ocean."
else:
    print "good to go"

I did try with your code in both global and function scopes with no errors.