13. not again why is mine not working, pls help!


#1

Here's my code:
from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
else:
print "You missed my battleship!"
board[guess_row][guess_col] = "X"
print_board(board)
if guess_row not in range(5) or guess_col not in range(5):
print "Oops, that's not even in the ocean."
else:
print "You missed my battleship!"
elif board[guess_row][guess_col] == "X":
print "You guessed that one already!"
else:
board[guess_row][guess_col] == "X"
print "You missed my battleship!"

it says:
File "python", line 38
elif board[guess_row][guess_col] == "X":
^
SyntaxError: invalid syntax

But i really don't know why so can someone pls help me out! Thx so much for your help


#2

Put your elif before your else.


#3

Thanks that worked for me! but why does the elif have to be before the else?


#4

thx that worked for me!!


#5

Elif is short for "else if". I think for 'if' structures, you always have to end with an 'else'; you can't end with an 'if'


#6

The code runs fine but when i repeat a guess it does not give the desired output "You guessed that one already."


#7

could you paste your code so we can see what to has to be fixed


#8

Write your code below!

if guess_row==ship_row and guess_col==ship_col:
print "Congratulations! You sank my battleship!"

elif board[guess_row][guess_col]=="X":
print "You guessed that one already."

else:

if guess_row not in range(5) or guess_col not in range(5):
    print "Oops, that's not even in the ocean."

else:
    print " You missed my battleship!"
    board[guess_row][guess_col]="X"