12. Bad Aim


#1


Hello, I'm stuck with my code, which gives no errors and appears ok to codeacademy. Still if I input guess_row = 3 and guess_col = 2, the code will output "Oops, that's not even in the ocean.", even if it is supposed to be in the grid. Why this? where am I wrong? Thanks for help :smiley:


 from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
elif guess_row or guess_col not in range(5):
    print "Oops, that's not even in the ocean."
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print print_board(board)


#2

if you use a or or and operator, you need to check condition at both sides of the or operator:

elif guess_row not in range(5) or guess_col not in range(5):

if you don't, guess_row will be true (positive integers are considered true), so the if statement evaluates to true, and will run


#3

This is my code
if guess_col==ship_col and guess_row==ship_row:
print "Congratulations! You sank my battleship!"
elif guess_row not in range(5) or guess_col not in range(5):
print "Oops,that's not even in the ocean"
else:
print "You missed my battleship!"
board[guess_row][guess_col]="X"
print print_board(board)
And am getting this error
Oops, try again. Make sure you print "Oops, that's not even in the ocean." if the user guesses a row or column that is off the board.
Some help


#4

strings printed should be an exact match, copy it from the instructions